PMD Results
The following document contains the results of PMD 7.20.0.
Violations By Priority
Priority 3
io/github/tonywasher/joceanus/gordianknot/impl/core/agree/GordianCoreAgreementFactory.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'theSignerCertificate'. | 70 |
| UnusedPrivateField | Avoid unused private fields such as 'theSignSpec'. | 75 |
io/github/tonywasher/joceanus/gordianknot/impl/core/kdf/GordianHKDFEngine.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'isPrimary'. | 49 |
io/github/tonywasher/joceanus/gordianknot/impl/core/stream/GordianLZMAInputStream.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 141–143 |
io/github/tonywasher/joceanus/gordianknot/impl/core/stream/GordianStreamManager.java
| Rule | Violation | Line |
|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 281–283 |
| EmptyCatchBlock | Avoid empty catch blocks | 294–296 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/digests/GordianGroestlDigest.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'ROUNDS512'. | 127 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/modes/GordianGCMSIVBlockCipher.java
| Rule | Violation | Line |
|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'numHashed'. | 790 |
Priority 4
io/github/tonywasher/joceanus/gordianknot/api/digest/GordianDigestSubSpec.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GordianDigestState': 'STATE512' is already in scope because it is declared in an enclosing type | 354 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/digests/GordianGroestlDigest.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `ROWS * COLS512`. | 125 |
| UselessParentheses | Useless parentheses around `ROWS * COLS1024`. | 126 |
| UselessParentheses | Useless parentheses around `(rotl64(a, 8) & 0x000000FF000000FFL) | (rotl64(...`. | 493–496 |
| UselessParentheses | Useless parentheses around `(msglen - index) / size`. | 904 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/digests/GordianJHDigest.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `((x & 0x5555555555555555L) << 1) | ((x & 0xaaaa...`. | 355 |
| UselessParentheses | Useless parentheses around `((x & 0x3333333333333333L) << 2) | ((x & 0xcccc...`. | 360 |
| UselessParentheses | Useless parentheses around `((x & 0x0f0f0f0f0f0f0f0fL) << 4) | ((x & 0xf0f0...`. | 365 |
| UselessParentheses | Useless parentheses around `((x & 0x00ff00ff00ff00ffL) << 8) | ((x & 0xff00...`. | 373 |
| UselessParentheses | Useless parentheses around `((x & 0x0000ffff0000ffffL) << 16) | ((x & 0xfff...`. | 381 |
| UselessParentheses | Useless parentheses around `(x << 32) | (x >>> 32)`. | 389 |
| UselessParentheses | Useless parentheses around `cc`. | 440 |
| UselessParentheses | Useless parentheses around `cc`. | 441 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/digests/GordianSkeinBase.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `(tweak[1] & T1_FIRST) != 0`. | 387 |
| UselessParentheses | Useless parentheses around `(tweak[1] & T1_FINAL) != 0`. | 399 |
| UselessParentheses | Useless parentheses around `len - copied`. | 506 |
| UselessParentheses | Useless parentheses around `(outputSizeBytes + blockSize - 1) / blockSize`. | 870 |
| UselessParentheses | Useless parentheses around `(outputBytes + 8 - 1) / 8`. | 920 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianAnubisEngine.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `BLOCKSIZE / 8`. | 41 |
| UselessParentheses | Useless parentheses around `key[pos + 3]`. | 517 |
| UselessParentheses | Useless parentheses around `kappa[nState - 1]`. | 530 |
| UselessParentheses | Useless parentheses around `k0`. | 536 |
| UselessParentheses | Useless parentheses around `k1`. | 541 |
| UselessParentheses | Useless parentheses around `k2`. | 546 |
| UselessParentheses | Useless parentheses around `kappa[i]`. | 547 |
| UselessParentheses | Useless parentheses around `k3`. | 551 |
| UselessParentheses | Useless parentheses around `kappa[j]`. | 583 |
| UselessParentheses | Useless parentheses around `v`. | 608 |
| UselessParentheses | Useless parentheses around `inBuffer[pos + 3]`. | 637 |
| UselessParentheses | Useless parentheses around `state[0]`. | 660 |
| UselessParentheses | Useless parentheses around `state[1]`. | 661 |
| UselessParentheses | Useless parentheses around `state[2]`. | 662 |
| UselessParentheses | Useless parentheses around `state[3]`. | 663 |
| UselessParentheses | Useless parentheses around `state[0]`. | 689 |
| UselessParentheses | Useless parentheses around `state[1]`. | 690 |
| UselessParentheses | Useless parentheses around `state[2]`. | 691 |
| UselessParentheses | Useless parentheses around `state[3]`. | 692 |
| UselessParentheses | Useless parentheses around `w`. | 703 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianBlake2XEngine.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 94 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianBlake3Engine.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 90 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianMARSEngine.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `BLOCKSIZE / 8`. | 39 |
| UselessParentheses | Useless parentheses around `(x >>> n) | (x << (32 - n))`. | 211 |
| UselessParentheses | Useless parentheses around `(x << n) | (x >>> (32 - n))`. | 215 |
| UselessParentheses | Useless parentheses around `w`. | 573 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianRabbitEngine.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 136 |
| UselessParentheses | Useless parentheses around `h ^ l`. | 243 |
| UselessParentheses | Useless parentheses around `(v << n) | (v >>> (32 - n))`. | 280 |
| UselessParentheses | Useless parentheses around `v`. | 280 |
| UselessParentheses | Useless parentheses around `n`. | 280 |
| UselessParentheses | Useless parentheses around `v`. | 280 |
| UselessParentheses | Useless parentheses around `n`. | 280 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianSkeinXofEngine.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 95 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianSnow3GEngine.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 173 |
| UselessParentheses | Useless parentheses around `val`. | 277 |
| UselessParentheses | Useless parentheses around `(mulXpow(c, 23, 0xa9) << 24) | (mulXpow(c, 245,...`. | 315–318 |
| UselessParentheses | Useless parentheses around `mulXpow(c, 239, 0xa9)`. | 318 |
| UselessParentheses | Useless parentheses around `(mulXpow(c, 16, 0xa9) << 24) | (mulXpow(c, 39, ...`. | 327–330 |
| UselessParentheses | Useless parentheses around `mulXpow(c, 64, 0xa9)`. | 330 |
| UselessParentheses | Useless parentheses around `w`. | 342 |
| UselessParentheses | Useless parentheses around `mulX(srw0, 0x1b)`. | 343 |
| UselessParentheses | Useless parentheses around `srw1`. | 344 |
| UselessParentheses | Useless parentheses around `srw2`. | 345 |
| UselessParentheses | Useless parentheses around `mulX(srw3, 0x1b) ^ srw3`. | 346 |
| UselessParentheses | Useless parentheses around `mulX(srw3, 0x1b)`. | 346 |
| UselessParentheses | Useless parentheses around `mulX(srw0, 0x1b) ^ srw0`. | 348 |
| UselessParentheses | Useless parentheses around `mulX(srw0, 0x1b)`. | 348 |
| UselessParentheses | Useless parentheses around `mulX(srw1, 0x1b)`. | 349 |
| UselessParentheses | Useless parentheses around `srw2`. | 350 |
| UselessParentheses | Useless parentheses around `srw3`. | 351 |
| UselessParentheses | Useless parentheses around `srw0`. | 353 |
| UselessParentheses | Useless parentheses around `mulX(srw1, 0x1b) ^ srw1`. | 354 |
| UselessParentheses | Useless parentheses around `mulX(srw1, 0x1b)`. | 354 |
| UselessParentheses | Useless parentheses around `mulX(srw2, 0x1b)`. | 355 |
| UselessParentheses | Useless parentheses around `srw3`. | 356 |
| UselessParentheses | Useless parentheses around `srw0`. | 358 |
| UselessParentheses | Useless parentheses around `srw1`. | 359 |
| UselessParentheses | Useless parentheses around `mulX(srw2, 0x1b) ^ srw2`. | 360 |
| UselessParentheses | Useless parentheses around `mulX(srw2, 0x1b)`. | 360 |
| UselessParentheses | Useless parentheses around `mulX(srw3, 0x1b)`. | 361 |
| UselessParentheses | Useless parentheses around `(r0 << 24) | (r1 << 16) | (r2 << 8) | r3`. | 363–364 |
| UselessParentheses | Useless parentheses around `r0`. | 363 |
| UselessParentheses | Useless parentheses around `r1`. | 363 |
| UselessParentheses | Useless parentheses around `r2`. | 363 |
| UselessParentheses | Useless parentheses around `r3`. | 364 |
| UselessParentheses | Useless parentheses around `w`. | 376 |
| UselessParentheses | Useless parentheses around `mulX(sqw0, 0x69)`. | 377 |
| UselessParentheses | Useless parentheses around `sqw1`. | 378 |
| UselessParentheses | Useless parentheses around `sqw2`. | 379 |
| UselessParentheses | Useless parentheses around `mulX(sqw3, 0x69) ^ sqw3`. | 380 |
| UselessParentheses | Useless parentheses around `mulX(sqw3, 0x69)`. | 380 |
| UselessParentheses | Useless parentheses around `mulX(sqw0, 0x69) ^ sqw0`. | 382 |
| UselessParentheses | Useless parentheses around `mulX(sqw0, 0x69)`. | 382 |
| UselessParentheses | Useless parentheses around `mulX(sqw1, 0x69)`. | 383 |
| UselessParentheses | Useless parentheses around `sqw2`. | 384 |
| UselessParentheses | Useless parentheses around `sqw3`. | 385 |
| UselessParentheses | Useless parentheses around `sqw0`. | 387 |
| UselessParentheses | Useless parentheses around `mulX(sqw1, 0x69) ^ sqw1`. | 388 |
| UselessParentheses | Useless parentheses around `mulX(sqw1, 0x69)`. | 388 |
| UselessParentheses | Useless parentheses around `mulX(sqw2, 0x69)`. | 389 |
| UselessParentheses | Useless parentheses around `sqw3`. | 390 |
| UselessParentheses | Useless parentheses around `sqw0`. | 392 |
| UselessParentheses | Useless parentheses around `sqw1`. | 393 |
| UselessParentheses | Useless parentheses around `mulX(sqw2, 0x69) ^ sqw2`. | 394 |
| UselessParentheses | Useless parentheses around `mulX(sqw2, 0x69)`. | 394 |
| UselessParentheses | Useless parentheses around `mulX(sqw3, 0x69)`. | 395 |
| UselessParentheses | Useless parentheses around `(r0 << 24) | (r1 << 16) | (r2 << 8) | r3`. | 397–398 |
| UselessParentheses | Useless parentheses around `r0`. | 397 |
| UselessParentheses | Useless parentheses around `r1`. | 397 |
| UselessParentheses | Useless parentheses around `r2`. | 397 |
| UselessParentheses | Useless parentheses around `r3`. | 398 |
| UselessParentheses | Useless parentheses around `((lfsrState[0] << 8) & 0xffffff00) ^ mulAlpha((...`. | 407–413 |
| UselessParentheses | Useless parentheses around `mulAlpha((byte) (lfsrState[0] >>> 24) & 0xff)`. | 408 |
| UselessParentheses | Useless parentheses around `lfsrState[2]`. | 409 |
| UselessParentheses | Useless parentheses around `divAlpha((byte) lfsrState[11] & 0xff)`. | 411 |
| UselessParentheses | Useless parentheses around `lfsrState[11]`. | 411 |
| UselessParentheses | Useless parentheses around `f`. | 412 |
| UselessParentheses | Useless parentheses around `((lfsrState[0] << 8) & 0xffffff00) ^ mulAlpha((...`. | 437–442 |
| UselessParentheses | Useless parentheses around `mulAlpha((byte) (lfsrState[0] >>> 24) & 0xff)`. | 438 |
| UselessParentheses | Useless parentheses around `lfsrState[2]`. | 439 |
| UselessParentheses | Useless parentheses around `divAlpha((byte) lfsrState[11] & 0xff)`. | 441 |
| UselessParentheses | Useless parentheses around `lfsrState[11]`. | 441 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianSosemanukEngine.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 88 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 0`. | 325 |
| UselessParentheses | Useless parentheses around `0`. | 325 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (0 + 1)`. | 327 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (0 + 2)`. | 329 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (0 + 3)`. | 331 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 4`. | 360 |
| UselessParentheses | Useless parentheses around `4`. | 360 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (4 + 1)`. | 362 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (4 + 2)`. | 364 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (4 + 3)`. | 366 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 8`. | 392 |
| UselessParentheses | Useless parentheses around `8`. | 392 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (8 + 1)`. | 394 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (8 + 2)`. | 396 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (8 + 3)`. | 398 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 12`. | 426 |
| UselessParentheses | Useless parentheses around `12`. | 426 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (12 + 1)`. | 428 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (12 + 2)`. | 430 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (12 + 3)`. | 432 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 16`. | 460 |
| UselessParentheses | Useless parentheses around `16`. | 460 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (16 + 1)`. | 462 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (16 + 2)`. | 464 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (16 + 3)`. | 466 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 20`. | 496 |
| UselessParentheses | Useless parentheses around `20`. | 496 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (20 + 1)`. | 498 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (20 + 2)`. | 500 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (20 + 3)`. | 502 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 24`. | 530 |
| UselessParentheses | Useless parentheses around `24`. | 530 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (24 + 1)`. | 532 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (24 + 2)`. | 534 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (24 + 3)`. | 536 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 28`. | 565 |
| UselessParentheses | Useless parentheses around `28`. | 565 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (28 + 1)`. | 567 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (28 + 2)`. | 569 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (28 + 3)`. | 571 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 32`. | 601 |
| UselessParentheses | Useless parentheses around `32`. | 601 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (32 + 1)`. | 603 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (32 + 2)`. | 605 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (32 + 3)`. | 607 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 36`. | 636 |
| UselessParentheses | Useless parentheses around `36`. | 636 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (36 + 1)`. | 638 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (36 + 2)`. | 640 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (36 + 3)`. | 642 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 40`. | 668 |
| UselessParentheses | Useless parentheses around `40`. | 668 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (40 + 1)`. | 670 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (40 + 2)`. | 672 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (40 + 3)`. | 674 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 44`. | 702 |
| UselessParentheses | Useless parentheses around `44`. | 702 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (44 + 1)`. | 704 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (44 + 2)`. | 706 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (44 + 3)`. | 708 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 48`. | 736 |
| UselessParentheses | Useless parentheses around `48`. | 736 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (48 + 1)`. | 738 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (48 + 2)`. | 740 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (48 + 3)`. | 742 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 52`. | 772 |
| UselessParentheses | Useless parentheses around `52`. | 772 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (52 + 1)`. | 774 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (52 + 2)`. | 776 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (52 + 3)`. | 778 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 56`. | 806 |
| UselessParentheses | Useless parentheses around `56`. | 806 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (56 + 1)`. | 808 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (56 + 2)`. | 810 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (56 + 3)`. | 812 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 60`. | 841 |
| UselessParentheses | Useless parentheses around `60`. | 841 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (60 + 1)`. | 843 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (60 + 2)`. | 845 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (60 + 3)`. | 847 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 64`. | 877 |
| UselessParentheses | Useless parentheses around `64`. | 877 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (64 + 1)`. | 879 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (64 + 2)`. | 881 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (64 + 3)`. | 883 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 68`. | 912 |
| UselessParentheses | Useless parentheses around `68`. | 912 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (68 + 1)`. | 914 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (68 + 2)`. | 916 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (68 + 3)`. | 918 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 72`. | 944 |
| UselessParentheses | Useless parentheses around `72`. | 944 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (72 + 1)`. | 946 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (72 + 2)`. | 948 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (72 + 3)`. | 950 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 76`. | 978 |
| UselessParentheses | Useless parentheses around `76`. | 978 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (76 + 1)`. | 980 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (76 + 2)`. | 982 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (76 + 3)`. | 984 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 80`. | 1012 |
| UselessParentheses | Useless parentheses around `80`. | 1012 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (80 + 1)`. | 1014 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (80 + 2)`. | 1016 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (80 + 3)`. | 1018 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 84`. | 1048 |
| UselessParentheses | Useless parentheses around `84`. | 1048 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (84 + 1)`. | 1050 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (84 + 2)`. | 1052 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (84 + 3)`. | 1054 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 88`. | 1082 |
| UselessParentheses | Useless parentheses around `88`. | 1082 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (88 + 1)`. | 1084 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (88 + 2)`. | 1086 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (88 + 3)`. | 1088 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 92`. | 1117 |
| UselessParentheses | Useless parentheses around `92`. | 1117 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (92 + 1)`. | 1119 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (92 + 2)`. | 1121 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (92 + 3)`. | 1123 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 96`. | 1153 |
| UselessParentheses | Useless parentheses around `96`. | 1153 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (96 + 1)`. | 1155 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (96 + 2)`. | 1157 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (96 + 3)`. | 1159 |
| UselessParentheses | Useless parentheses around `(s0 << 8) ^ MUL_ALPHA[s0 >>> 24]`. | 2107 |
| UselessParentheses | Useless parentheses around `(s3 >>> 8) ^ DIV_ALPHA[s3 & 0xFF]`. | 2108 |
| UselessParentheses | Useless parentheses around `(s1 << 8) ^ MUL_ALPHA[s1 >>> 24]`. | 2115 |
| UselessParentheses | Useless parentheses around `(s4 >>> 8) ^ DIV_ALPHA[s4 & 0xFF]`. | 2116 |
| UselessParentheses | Useless parentheses around `(s2 << 8) ^ MUL_ALPHA[s2 >>> 24]`. | 2123 |
| UselessParentheses | Useless parentheses around `(s5 >>> 8) ^ DIV_ALPHA[s5 & 0xFF]`. | 2124 |
| UselessParentheses | Useless parentheses around `(s3 << 8) ^ MUL_ALPHA[s3 >>> 24]`. | 2131 |
| UselessParentheses | Useless parentheses around `(s6 >>> 8) ^ DIV_ALPHA[s6 & 0xFF]`. | 2132 |
| UselessParentheses | Useless parentheses around `(s4 << 8) ^ MUL_ALPHA[s4 >>> 24]`. | 2167 |
| UselessParentheses | Useless parentheses around `(s7 >>> 8) ^ DIV_ALPHA[s7 & 0xFF]`. | 2168 |
| UselessParentheses | Useless parentheses around `(s5 << 8) ^ MUL_ALPHA[s5 >>> 24]`. | 2175 |
| UselessParentheses | Useless parentheses around `(s8 >>> 8) ^ DIV_ALPHA[s8 & 0xFF]`. | 2176 |
| UselessParentheses | Useless parentheses around `(s6 << 8) ^ MUL_ALPHA[s6 >>> 24]`. | 2183 |
| UselessParentheses | Useless parentheses around `(s9 >>> 8) ^ DIV_ALPHA[s9 & 0xFF]`. | 2184 |
| UselessParentheses | Useless parentheses around `(s7 << 8) ^ MUL_ALPHA[s7 >>> 24]`. | 2191 |
| UselessParentheses | Useless parentheses around `(s0 >>> 8) ^ DIV_ALPHA[s0 & 0xFF]`. | 2192 |
| UselessParentheses | Useless parentheses around `(s8 << 8) ^ MUL_ALPHA[s8 >>> 24]`. | 2227 |
| UselessParentheses | Useless parentheses around `(s1 >>> 8) ^ DIV_ALPHA[s1 & 0xFF]`. | 2228 |
| UselessParentheses | Useless parentheses around `(s9 << 8) ^ MUL_ALPHA[s9 >>> 24]`. | 2235 |
| UselessParentheses | Useless parentheses around `(s2 >>> 8) ^ DIV_ALPHA[s2 & 0xFF]`. | 2236 |
| UselessParentheses | Useless parentheses around `(s0 << 8) ^ MUL_ALPHA[s0 >>> 24]`. | 2243 |
| UselessParentheses | Useless parentheses around `(s3 >>> 8) ^ DIV_ALPHA[s3 & 0xFF]`. | 2244 |
| UselessParentheses | Useless parentheses around `(s1 << 8) ^ MUL_ALPHA[s1 >>> 24]`. | 2251 |
| UselessParentheses | Useless parentheses around `(s4 >>> 8) ^ DIV_ALPHA[s4 & 0xFF]`. | 2252 |
| UselessParentheses | Useless parentheses around `(s2 << 8) ^ MUL_ALPHA[s2 >>> 24]`. | 2287 |
| UselessParentheses | Useless parentheses around `(s5 >>> 8) ^ DIV_ALPHA[s5 & 0xFF]`. | 2288 |
| UselessParentheses | Useless parentheses around `(s3 << 8) ^ MUL_ALPHA[s3 >>> 24]`. | 2295 |
| UselessParentheses | Useless parentheses around `(s6 >>> 8) ^ DIV_ALPHA[s6 & 0xFF]`. | 2296 |
| UselessParentheses | Useless parentheses around `(s4 << 8) ^ MUL_ALPHA[s4 >>> 24]`. | 2303 |
| UselessParentheses | Useless parentheses around `(s7 >>> 8) ^ DIV_ALPHA[s7 & 0xFF]`. | 2304 |
| UselessParentheses | Useless parentheses around `(s5 << 8) ^ MUL_ALPHA[s5 >>> 24]`. | 2311 |
| UselessParentheses | Useless parentheses around `(s8 >>> 8) ^ DIV_ALPHA[s8 & 0xFF]`. | 2312 |
| UselessParentheses | Useless parentheses around `(s6 << 8) ^ MUL_ALPHA[s6 >>> 24]`. | 2347 |
| UselessParentheses | Useless parentheses around `(s9 >>> 8) ^ DIV_ALPHA[s9 & 0xFF]`. | 2348 |
| UselessParentheses | Useless parentheses around `(s7 << 8) ^ MUL_ALPHA[s7 >>> 24]`. | 2355 |
| UselessParentheses | Useless parentheses around `(s0 >>> 8) ^ DIV_ALPHA[s0 & 0xFF]`. | 2356 |
| UselessParentheses | Useless parentheses around `(s8 << 8) ^ MUL_ALPHA[s8 >>> 24]`. | 2363 |
| UselessParentheses | Useless parentheses around `(s1 >>> 8) ^ DIV_ALPHA[s1 & 0xFF]`. | 2364 |
| UselessParentheses | Useless parentheses around `(s9 << 8) ^ MUL_ALPHA[s9 >>> 24]`. | 2371 |
| UselessParentheses | Useless parentheses around `(s2 >>> 8) ^ DIV_ALPHA[s2 & 0xFF]`. | 2372 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianSpeckEngine.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `numWords - 2`. | 203 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianXChaCha20Engine.java
| Rule | Violation | Line |
|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Salsa20Engine': 'DEFAULT_ROUNDS' is already in scope because it is inherited by an enclosing type | 64 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianZuc128Engine.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 186 |
| UselessParentheses | Useless parentheses around `((x << k) | (x >>> (31 - k))) & 0x7FFFFFFF`. | 321 |
| UselessParentheses | Useless parentheses around `x`. | 321 |
| UselessParentheses | Useless parentheses around `x`. | 321 |
| UselessParentheses | Useless parentheses around `(a << k) | (a >>> (32 - k))`. | 415 |
| UselessParentheses | Useless parentheses around `a`. | 415 |
| UselessParentheses | Useless parentheses around `a`. | 415 |
| UselessParentheses | Useless parentheses around `x ^ rot(x, 2) ^ rot(x, 10) ^ rot(x, 18) ^ rot(x...`. | 425 |
| UselessParentheses | Useless parentheses around `x ^ rot(x, 8) ^ rot(x, 14) ^ rot(x, 22) ^ rot(x...`. | 435 |
| UselessParentheses | Useless parentheses around `((a & 0xFF) << 24) | ((b & 0xFF) << 16) | ((c &...`. | 451 |
| UselessParentheses | Useless parentheses around `((a & 0xFF) << 23) | ((b & 0xFFFF) << 8) | (c &...`. | 483 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianZuc256Engine.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `((a & 0xFF) << 23) | ((b & 0xFF) << 16) | ((c &...`. | 122 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/modes/GordianGCMSIVBlockCipher.java
| Rule | Violation | Line |
|---|---|---|
| UselessParentheses | Useless parentheses around `MAX_DATALEN - pLen`. | 262 |
| UselessParentheses | Useless parentheses around `dataLimit - pLen`. | 292 |
Files
io/github/tonywasher/joceanus/gordianknot/api/digest/GordianDigestSubSpec.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'GordianDigestState': 'STATE512' is already in scope because it is declared in an enclosing type | 4 | 354 |
io/github/tonywasher/joceanus/gordianknot/impl/core/agree/GordianCoreAgreementFactory.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'theSignerCertificate'. | 3 | 70 |
| UnusedPrivateField | Avoid unused private fields such as 'theSignSpec'. | 3 | 75 |
io/github/tonywasher/joceanus/gordianknot/impl/core/kdf/GordianHKDFEngine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnusedPrivateField | Avoid unused private fields such as 'isPrimary'. | 3 | 49 |
io/github/tonywasher/joceanus/gordianknot/impl/core/stream/GordianLZMAInputStream.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 141–143 |
io/github/tonywasher/joceanus/gordianknot/impl/core/stream/GordianStreamManager.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 281–283 |
| EmptyCatchBlock | Avoid empty catch blocks | 3 | 294–296 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/digests/GordianGroestlDigest.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `ROWS * COLS512`. | 4 | 125 |
| UselessParentheses | Useless parentheses around `ROWS * COLS1024`. | 4 | 126 |
| UnusedPrivateField | Avoid unused private fields such as 'ROUNDS512'. | 3 | 127 |
| UselessParentheses | Useless parentheses around `(rotl64(a, 8) & 0x000000FF000000FFL) | (rotl64(...`. | 4 | 493–496 |
| UselessParentheses | Useless parentheses around `(msglen - index) / size`. | 4 | 904 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/digests/GordianJHDigest.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `((x & 0x5555555555555555L) << 1) | ((x & 0xaaaa...`. | 4 | 355 |
| UselessParentheses | Useless parentheses around `((x & 0x3333333333333333L) << 2) | ((x & 0xcccc...`. | 4 | 360 |
| UselessParentheses | Useless parentheses around `((x & 0x0f0f0f0f0f0f0f0fL) << 4) | ((x & 0xf0f0...`. | 4 | 365 |
| UselessParentheses | Useless parentheses around `((x & 0x00ff00ff00ff00ffL) << 8) | ((x & 0xff00...`. | 4 | 373 |
| UselessParentheses | Useless parentheses around `((x & 0x0000ffff0000ffffL) << 16) | ((x & 0xfff...`. | 4 | 381 |
| UselessParentheses | Useless parentheses around `(x << 32) | (x >>> 32)`. | 4 | 389 |
| UselessParentheses | Useless parentheses around `cc`. | 4 | 440 |
| UselessParentheses | Useless parentheses around `cc`. | 4 | 441 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/digests/GordianSkeinBase.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `(tweak[1] & T1_FIRST) != 0`. | 4 | 387 |
| UselessParentheses | Useless parentheses around `(tweak[1] & T1_FINAL) != 0`. | 4 | 399 |
| UselessParentheses | Useless parentheses around `len - copied`. | 4 | 506 |
| UselessParentheses | Useless parentheses around `(outputSizeBytes + blockSize - 1) / blockSize`. | 4 | 870 |
| UselessParentheses | Useless parentheses around `(outputBytes + 8 - 1) / 8`. | 4 | 920 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianAnubisEngine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `BLOCKSIZE / 8`. | 4 | 41 |
| UselessParentheses | Useless parentheses around `key[pos + 3]`. | 4 | 517 |
| UselessParentheses | Useless parentheses around `kappa[nState - 1]`. | 4 | 530 |
| UselessParentheses | Useless parentheses around `k0`. | 4 | 536 |
| UselessParentheses | Useless parentheses around `k1`. | 4 | 541 |
| UselessParentheses | Useless parentheses around `k2`. | 4 | 546 |
| UselessParentheses | Useless parentheses around `kappa[i]`. | 4 | 547 |
| UselessParentheses | Useless parentheses around `k3`. | 4 | 551 |
| UselessParentheses | Useless parentheses around `kappa[j]`. | 4 | 583 |
| UselessParentheses | Useless parentheses around `v`. | 4 | 608 |
| UselessParentheses | Useless parentheses around `inBuffer[pos + 3]`. | 4 | 637 |
| UselessParentheses | Useless parentheses around `state[0]`. | 4 | 660 |
| UselessParentheses | Useless parentheses around `state[1]`. | 4 | 661 |
| UselessParentheses | Useless parentheses around `state[2]`. | 4 | 662 |
| UselessParentheses | Useless parentheses around `state[3]`. | 4 | 663 |
| UselessParentheses | Useless parentheses around `state[0]`. | 4 | 689 |
| UselessParentheses | Useless parentheses around `state[1]`. | 4 | 690 |
| UselessParentheses | Useless parentheses around `state[2]`. | 4 | 691 |
| UselessParentheses | Useless parentheses around `state[3]`. | 4 | 692 |
| UselessParentheses | Useless parentheses around `w`. | 4 | 703 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianBlake2XEngine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 4 | 94 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianBlake3Engine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 4 | 90 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianMARSEngine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `BLOCKSIZE / 8`. | 4 | 39 |
| UselessParentheses | Useless parentheses around `(x >>> n) | (x << (32 - n))`. | 4 | 211 |
| UselessParentheses | Useless parentheses around `(x << n) | (x >>> (32 - n))`. | 4 | 215 |
| UselessParentheses | Useless parentheses around `w`. | 4 | 573 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianRabbitEngine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 4 | 136 |
| UselessParentheses | Useless parentheses around `h ^ l`. | 4 | 243 |
| UselessParentheses | Useless parentheses around `(v << n) | (v >>> (32 - n))`. | 4 | 280 |
| UselessParentheses | Useless parentheses around `v`. | 4 | 280 |
| UselessParentheses | Useless parentheses around `n`. | 4 | 280 |
| UselessParentheses | Useless parentheses around `v`. | 4 | 280 |
| UselessParentheses | Useless parentheses around `n`. | 4 | 280 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianSkeinXofEngine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 4 | 95 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianSnow3GEngine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 4 | 173 |
| UselessParentheses | Useless parentheses around `val`. | 4 | 277 |
| UselessParentheses | Useless parentheses around `(mulXpow(c, 23, 0xa9) << 24) | (mulXpow(c, 245,...`. | 4 | 315–318 |
| UselessParentheses | Useless parentheses around `mulXpow(c, 239, 0xa9)`. | 4 | 318 |
| UselessParentheses | Useless parentheses around `(mulXpow(c, 16, 0xa9) << 24) | (mulXpow(c, 39, ...`. | 4 | 327–330 |
| UselessParentheses | Useless parentheses around `mulXpow(c, 64, 0xa9)`. | 4 | 330 |
| UselessParentheses | Useless parentheses around `w`. | 4 | 342 |
| UselessParentheses | Useless parentheses around `mulX(srw0, 0x1b)`. | 4 | 343 |
| UselessParentheses | Useless parentheses around `srw1`. | 4 | 344 |
| UselessParentheses | Useless parentheses around `srw2`. | 4 | 345 |
| UselessParentheses | Useless parentheses around `mulX(srw3, 0x1b) ^ srw3`. | 4 | 346 |
| UselessParentheses | Useless parentheses around `mulX(srw3, 0x1b)`. | 4 | 346 |
| UselessParentheses | Useless parentheses around `mulX(srw0, 0x1b) ^ srw0`. | 4 | 348 |
| UselessParentheses | Useless parentheses around `mulX(srw0, 0x1b)`. | 4 | 348 |
| UselessParentheses | Useless parentheses around `mulX(srw1, 0x1b)`. | 4 | 349 |
| UselessParentheses | Useless parentheses around `srw2`. | 4 | 350 |
| UselessParentheses | Useless parentheses around `srw3`. | 4 | 351 |
| UselessParentheses | Useless parentheses around `srw0`. | 4 | 353 |
| UselessParentheses | Useless parentheses around `mulX(srw1, 0x1b) ^ srw1`. | 4 | 354 |
| UselessParentheses | Useless parentheses around `mulX(srw1, 0x1b)`. | 4 | 354 |
| UselessParentheses | Useless parentheses around `mulX(srw2, 0x1b)`. | 4 | 355 |
| UselessParentheses | Useless parentheses around `srw3`. | 4 | 356 |
| UselessParentheses | Useless parentheses around `srw0`. | 4 | 358 |
| UselessParentheses | Useless parentheses around `srw1`. | 4 | 359 |
| UselessParentheses | Useless parentheses around `mulX(srw2, 0x1b) ^ srw2`. | 4 | 360 |
| UselessParentheses | Useless parentheses around `mulX(srw2, 0x1b)`. | 4 | 360 |
| UselessParentheses | Useless parentheses around `mulX(srw3, 0x1b)`. | 4 | 361 |
| UselessParentheses | Useless parentheses around `(r0 << 24) | (r1 << 16) | (r2 << 8) | r3`. | 4 | 363–364 |
| UselessParentheses | Useless parentheses around `r0`. | 4 | 363 |
| UselessParentheses | Useless parentheses around `r1`. | 4 | 363 |
| UselessParentheses | Useless parentheses around `r2`. | 4 | 363 |
| UselessParentheses | Useless parentheses around `r3`. | 4 | 364 |
| UselessParentheses | Useless parentheses around `w`. | 4 | 376 |
| UselessParentheses | Useless parentheses around `mulX(sqw0, 0x69)`. | 4 | 377 |
| UselessParentheses | Useless parentheses around `sqw1`. | 4 | 378 |
| UselessParentheses | Useless parentheses around `sqw2`. | 4 | 379 |
| UselessParentheses | Useless parentheses around `mulX(sqw3, 0x69) ^ sqw3`. | 4 | 380 |
| UselessParentheses | Useless parentheses around `mulX(sqw3, 0x69)`. | 4 | 380 |
| UselessParentheses | Useless parentheses around `mulX(sqw0, 0x69) ^ sqw0`. | 4 | 382 |
| UselessParentheses | Useless parentheses around `mulX(sqw0, 0x69)`. | 4 | 382 |
| UselessParentheses | Useless parentheses around `mulX(sqw1, 0x69)`. | 4 | 383 |
| UselessParentheses | Useless parentheses around `sqw2`. | 4 | 384 |
| UselessParentheses | Useless parentheses around `sqw3`. | 4 | 385 |
| UselessParentheses | Useless parentheses around `sqw0`. | 4 | 387 |
| UselessParentheses | Useless parentheses around `mulX(sqw1, 0x69) ^ sqw1`. | 4 | 388 |
| UselessParentheses | Useless parentheses around `mulX(sqw1, 0x69)`. | 4 | 388 |
| UselessParentheses | Useless parentheses around `mulX(sqw2, 0x69)`. | 4 | 389 |
| UselessParentheses | Useless parentheses around `sqw3`. | 4 | 390 |
| UselessParentheses | Useless parentheses around `sqw0`. | 4 | 392 |
| UselessParentheses | Useless parentheses around `sqw1`. | 4 | 393 |
| UselessParentheses | Useless parentheses around `mulX(sqw2, 0x69) ^ sqw2`. | 4 | 394 |
| UselessParentheses | Useless parentheses around `mulX(sqw2, 0x69)`. | 4 | 394 |
| UselessParentheses | Useless parentheses around `mulX(sqw3, 0x69)`. | 4 | 395 |
| UselessParentheses | Useless parentheses around `(r0 << 24) | (r1 << 16) | (r2 << 8) | r3`. | 4 | 397–398 |
| UselessParentheses | Useless parentheses around `r0`. | 4 | 397 |
| UselessParentheses | Useless parentheses around `r1`. | 4 | 397 |
| UselessParentheses | Useless parentheses around `r2`. | 4 | 397 |
| UselessParentheses | Useless parentheses around `r3`. | 4 | 398 |
| UselessParentheses | Useless parentheses around `((lfsrState[0] << 8) & 0xffffff00) ^ mulAlpha((...`. | 4 | 407–413 |
| UselessParentheses | Useless parentheses around `mulAlpha((byte) (lfsrState[0] >>> 24) & 0xff)`. | 4 | 408 |
| UselessParentheses | Useless parentheses around `lfsrState[2]`. | 4 | 409 |
| UselessParentheses | Useless parentheses around `divAlpha((byte) lfsrState[11] & 0xff)`. | 4 | 411 |
| UselessParentheses | Useless parentheses around `lfsrState[11]`. | 4 | 411 |
| UselessParentheses | Useless parentheses around `f`. | 4 | 412 |
| UselessParentheses | Useless parentheses around `((lfsrState[0] << 8) & 0xffffff00) ^ mulAlpha((...`. | 4 | 437–442 |
| UselessParentheses | Useless parentheses around `mulAlpha((byte) (lfsrState[0] >>> 24) & 0xff)`. | 4 | 438 |
| UselessParentheses | Useless parentheses around `lfsrState[2]`. | 4 | 439 |
| UselessParentheses | Useless parentheses around `divAlpha((byte) lfsrState[11] & 0xff)`. | 4 | 441 |
| UselessParentheses | Useless parentheses around `lfsrState[11]`. | 4 | 441 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianSosemanukEngine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 4 | 88 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 0`. | 4 | 325 |
| UselessParentheses | Useless parentheses around `0`. | 4 | 325 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (0 + 1)`. | 4 | 327 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (0 + 2)`. | 4 | 329 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (0 + 3)`. | 4 | 331 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 4`. | 4 | 360 |
| UselessParentheses | Useless parentheses around `4`. | 4 | 360 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (4 + 1)`. | 4 | 362 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (4 + 2)`. | 4 | 364 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (4 + 3)`. | 4 | 366 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 8`. | 4 | 392 |
| UselessParentheses | Useless parentheses around `8`. | 4 | 392 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (8 + 1)`. | 4 | 394 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (8 + 2)`. | 4 | 396 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (8 + 3)`. | 4 | 398 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 12`. | 4 | 426 |
| UselessParentheses | Useless parentheses around `12`. | 4 | 426 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (12 + 1)`. | 4 | 428 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (12 + 2)`. | 4 | 430 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (12 + 3)`. | 4 | 432 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 16`. | 4 | 460 |
| UselessParentheses | Useless parentheses around `16`. | 4 | 460 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (16 + 1)`. | 4 | 462 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (16 + 2)`. | 4 | 464 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (16 + 3)`. | 4 | 466 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 20`. | 4 | 496 |
| UselessParentheses | Useless parentheses around `20`. | 4 | 496 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (20 + 1)`. | 4 | 498 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (20 + 2)`. | 4 | 500 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (20 + 3)`. | 4 | 502 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 24`. | 4 | 530 |
| UselessParentheses | Useless parentheses around `24`. | 4 | 530 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (24 + 1)`. | 4 | 532 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (24 + 2)`. | 4 | 534 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (24 + 3)`. | 4 | 536 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 28`. | 4 | 565 |
| UselessParentheses | Useless parentheses around `28`. | 4 | 565 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (28 + 1)`. | 4 | 567 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (28 + 2)`. | 4 | 569 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (28 + 3)`. | 4 | 571 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 32`. | 4 | 601 |
| UselessParentheses | Useless parentheses around `32`. | 4 | 601 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (32 + 1)`. | 4 | 603 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (32 + 2)`. | 4 | 605 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (32 + 3)`. | 4 | 607 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 36`. | 4 | 636 |
| UselessParentheses | Useless parentheses around `36`. | 4 | 636 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (36 + 1)`. | 4 | 638 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (36 + 2)`. | 4 | 640 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (36 + 3)`. | 4 | 642 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 40`. | 4 | 668 |
| UselessParentheses | Useless parentheses around `40`. | 4 | 668 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (40 + 1)`. | 4 | 670 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (40 + 2)`. | 4 | 672 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (40 + 3)`. | 4 | 674 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 44`. | 4 | 702 |
| UselessParentheses | Useless parentheses around `44`. | 4 | 702 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (44 + 1)`. | 4 | 704 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (44 + 2)`. | 4 | 706 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (44 + 3)`. | 4 | 708 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 48`. | 4 | 736 |
| UselessParentheses | Useless parentheses around `48`. | 4 | 736 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (48 + 1)`. | 4 | 738 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (48 + 2)`. | 4 | 740 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (48 + 3)`. | 4 | 742 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 52`. | 4 | 772 |
| UselessParentheses | Useless parentheses around `52`. | 4 | 772 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (52 + 1)`. | 4 | 774 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (52 + 2)`. | 4 | 776 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (52 + 3)`. | 4 | 778 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 56`. | 4 | 806 |
| UselessParentheses | Useless parentheses around `56`. | 4 | 806 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (56 + 1)`. | 4 | 808 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (56 + 2)`. | 4 | 810 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (56 + 3)`. | 4 | 812 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 60`. | 4 | 841 |
| UselessParentheses | Useless parentheses around `60`. | 4 | 841 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (60 + 1)`. | 4 | 843 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (60 + 2)`. | 4 | 845 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (60 + 3)`. | 4 | 847 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 64`. | 4 | 877 |
| UselessParentheses | Useless parentheses around `64`. | 4 | 877 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (64 + 1)`. | 4 | 879 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (64 + 2)`. | 4 | 881 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (64 + 3)`. | 4 | 883 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 68`. | 4 | 912 |
| UselessParentheses | Useless parentheses around `68`. | 4 | 912 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (68 + 1)`. | 4 | 914 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (68 + 2)`. | 4 | 916 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (68 + 3)`. | 4 | 918 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 72`. | 4 | 944 |
| UselessParentheses | Useless parentheses around `72`. | 4 | 944 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (72 + 1)`. | 4 | 946 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (72 + 2)`. | 4 | 948 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (72 + 3)`. | 4 | 950 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 76`. | 4 | 978 |
| UselessParentheses | Useless parentheses around `76`. | 4 | 978 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (76 + 1)`. | 4 | 980 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (76 + 2)`. | 4 | 982 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (76 + 3)`. | 4 | 984 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 80`. | 4 | 1012 |
| UselessParentheses | Useless parentheses around `80`. | 4 | 1012 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (80 + 1)`. | 4 | 1014 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (80 + 2)`. | 4 | 1016 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (80 + 3)`. | 4 | 1018 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 84`. | 4 | 1048 |
| UselessParentheses | Useless parentheses around `84`. | 4 | 1048 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (84 + 1)`. | 4 | 1050 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (84 + 2)`. | 4 | 1052 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (84 + 3)`. | 4 | 1054 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 88`. | 4 | 1082 |
| UselessParentheses | Useless parentheses around `88`. | 4 | 1082 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (88 + 1)`. | 4 | 1084 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (88 + 2)`. | 4 | 1086 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (88 + 3)`. | 4 | 1088 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 92`. | 4 | 1117 |
| UselessParentheses | Useless parentheses around `92`. | 4 | 1117 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (92 + 1)`. | 4 | 1119 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (92 + 2)`. | 4 | 1121 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (92 + 3)`. | 4 | 1123 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ 96`. | 4 | 1153 |
| UselessParentheses | Useless parentheses around `96`. | 4 | 1153 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (96 + 1)`. | 4 | 1155 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (96 + 2)`. | 4 | 1157 |
| UselessParentheses | Useless parentheses around `0x9E3779B9 ^ (96 + 3)`. | 4 | 1159 |
| UselessParentheses | Useless parentheses around `(s0 << 8) ^ MUL_ALPHA[s0 >>> 24]`. | 4 | 2107 |
| UselessParentheses | Useless parentheses around `(s3 >>> 8) ^ DIV_ALPHA[s3 & 0xFF]`. | 4 | 2108 |
| UselessParentheses | Useless parentheses around `(s1 << 8) ^ MUL_ALPHA[s1 >>> 24]`. | 4 | 2115 |
| UselessParentheses | Useless parentheses around `(s4 >>> 8) ^ DIV_ALPHA[s4 & 0xFF]`. | 4 | 2116 |
| UselessParentheses | Useless parentheses around `(s2 << 8) ^ MUL_ALPHA[s2 >>> 24]`. | 4 | 2123 |
| UselessParentheses | Useless parentheses around `(s5 >>> 8) ^ DIV_ALPHA[s5 & 0xFF]`. | 4 | 2124 |
| UselessParentheses | Useless parentheses around `(s3 << 8) ^ MUL_ALPHA[s3 >>> 24]`. | 4 | 2131 |
| UselessParentheses | Useless parentheses around `(s6 >>> 8) ^ DIV_ALPHA[s6 & 0xFF]`. | 4 | 2132 |
| UselessParentheses | Useless parentheses around `(s4 << 8) ^ MUL_ALPHA[s4 >>> 24]`. | 4 | 2167 |
| UselessParentheses | Useless parentheses around `(s7 >>> 8) ^ DIV_ALPHA[s7 & 0xFF]`. | 4 | 2168 |
| UselessParentheses | Useless parentheses around `(s5 << 8) ^ MUL_ALPHA[s5 >>> 24]`. | 4 | 2175 |
| UselessParentheses | Useless parentheses around `(s8 >>> 8) ^ DIV_ALPHA[s8 & 0xFF]`. | 4 | 2176 |
| UselessParentheses | Useless parentheses around `(s6 << 8) ^ MUL_ALPHA[s6 >>> 24]`. | 4 | 2183 |
| UselessParentheses | Useless parentheses around `(s9 >>> 8) ^ DIV_ALPHA[s9 & 0xFF]`. | 4 | 2184 |
| UselessParentheses | Useless parentheses around `(s7 << 8) ^ MUL_ALPHA[s7 >>> 24]`. | 4 | 2191 |
| UselessParentheses | Useless parentheses around `(s0 >>> 8) ^ DIV_ALPHA[s0 & 0xFF]`. | 4 | 2192 |
| UselessParentheses | Useless parentheses around `(s8 << 8) ^ MUL_ALPHA[s8 >>> 24]`. | 4 | 2227 |
| UselessParentheses | Useless parentheses around `(s1 >>> 8) ^ DIV_ALPHA[s1 & 0xFF]`. | 4 | 2228 |
| UselessParentheses | Useless parentheses around `(s9 << 8) ^ MUL_ALPHA[s9 >>> 24]`. | 4 | 2235 |
| UselessParentheses | Useless parentheses around `(s2 >>> 8) ^ DIV_ALPHA[s2 & 0xFF]`. | 4 | 2236 |
| UselessParentheses | Useless parentheses around `(s0 << 8) ^ MUL_ALPHA[s0 >>> 24]`. | 4 | 2243 |
| UselessParentheses | Useless parentheses around `(s3 >>> 8) ^ DIV_ALPHA[s3 & 0xFF]`. | 4 | 2244 |
| UselessParentheses | Useless parentheses around `(s1 << 8) ^ MUL_ALPHA[s1 >>> 24]`. | 4 | 2251 |
| UselessParentheses | Useless parentheses around `(s4 >>> 8) ^ DIV_ALPHA[s4 & 0xFF]`. | 4 | 2252 |
| UselessParentheses | Useless parentheses around `(s2 << 8) ^ MUL_ALPHA[s2 >>> 24]`. | 4 | 2287 |
| UselessParentheses | Useless parentheses around `(s5 >>> 8) ^ DIV_ALPHA[s5 & 0xFF]`. | 4 | 2288 |
| UselessParentheses | Useless parentheses around `(s3 << 8) ^ MUL_ALPHA[s3 >>> 24]`. | 4 | 2295 |
| UselessParentheses | Useless parentheses around `(s6 >>> 8) ^ DIV_ALPHA[s6 & 0xFF]`. | 4 | 2296 |
| UselessParentheses | Useless parentheses around `(s4 << 8) ^ MUL_ALPHA[s4 >>> 24]`. | 4 | 2303 |
| UselessParentheses | Useless parentheses around `(s7 >>> 8) ^ DIV_ALPHA[s7 & 0xFF]`. | 4 | 2304 |
| UselessParentheses | Useless parentheses around `(s5 << 8) ^ MUL_ALPHA[s5 >>> 24]`. | 4 | 2311 |
| UselessParentheses | Useless parentheses around `(s8 >>> 8) ^ DIV_ALPHA[s8 & 0xFF]`. | 4 | 2312 |
| UselessParentheses | Useless parentheses around `(s6 << 8) ^ MUL_ALPHA[s6 >>> 24]`. | 4 | 2347 |
| UselessParentheses | Useless parentheses around `(s9 >>> 8) ^ DIV_ALPHA[s9 & 0xFF]`. | 4 | 2348 |
| UselessParentheses | Useless parentheses around `(s7 << 8) ^ MUL_ALPHA[s7 >>> 24]`. | 4 | 2355 |
| UselessParentheses | Useless parentheses around `(s0 >>> 8) ^ DIV_ALPHA[s0 & 0xFF]`. | 4 | 2356 |
| UselessParentheses | Useless parentheses around `(s8 << 8) ^ MUL_ALPHA[s8 >>> 24]`. | 4 | 2363 |
| UselessParentheses | Useless parentheses around `(s1 >>> 8) ^ DIV_ALPHA[s1 & 0xFF]`. | 4 | 2364 |
| UselessParentheses | Useless parentheses around `(s9 << 8) ^ MUL_ALPHA[s9 >>> 24]`. | 4 | 2371 |
| UselessParentheses | Useless parentheses around `(s2 >>> 8) ^ DIV_ALPHA[s2 & 0xFF]`. | 4 | 2372 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianSpeckEngine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `numWords - 2`. | 4 | 203 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianXChaCha20Engine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UnnecessaryFullyQualifiedName | Unnecessary qualifier 'Salsa20Engine': 'DEFAULT_ROUNDS' is already in scope because it is inherited by an enclosing type | 4 | 64 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianZuc128Engine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `myParams instanceof ParametersWithIV`. | 4 | 186 |
| UselessParentheses | Useless parentheses around `((x << k) | (x >>> (31 - k))) & 0x7FFFFFFF`. | 4 | 321 |
| UselessParentheses | Useless parentheses around `x`. | 4 | 321 |
| UselessParentheses | Useless parentheses around `x`. | 4 | 321 |
| UselessParentheses | Useless parentheses around `(a << k) | (a >>> (32 - k))`. | 4 | 415 |
| UselessParentheses | Useless parentheses around `a`. | 4 | 415 |
| UselessParentheses | Useless parentheses around `a`. | 4 | 415 |
| UselessParentheses | Useless parentheses around `x ^ rot(x, 2) ^ rot(x, 10) ^ rot(x, 18) ^ rot(x...`. | 4 | 425 |
| UselessParentheses | Useless parentheses around `x ^ rot(x, 8) ^ rot(x, 14) ^ rot(x, 22) ^ rot(x...`. | 4 | 435 |
| UselessParentheses | Useless parentheses around `((a & 0xFF) << 24) | ((b & 0xFF) << 16) | ((c &...`. | 4 | 451 |
| UselessParentheses | Useless parentheses around `((a & 0xFF) << 23) | ((b & 0xFFFF) << 8) | (c &...`. | 4 | 483 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/engines/GordianZuc256Engine.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `((a & 0xFF) << 23) | ((b & 0xFF) << 16) | ((c &...`. | 4 | 122 |
io/github/tonywasher/joceanus/gordianknot/impl/ext/modes/GordianGCMSIVBlockCipher.java
| Rule | Violation | Priority | Line |
|---|---|---|---|
| UselessParentheses | Useless parentheses around `MAX_DATALEN - pLen`. | 4 | 262 |
| UselessParentheses | Useless parentheses around `dataLimit - pLen`. | 4 | 292 |
| UnusedPrivateField | Avoid unused private fields such as 'numHashed'. | 3 | 790 |