PMD Results

The following document contains the results of PMD 7.25.0.

Violations By Priority

Priority 3

io/github/tonywasher/joceanus/moneywise/atlas/data/analysis/buckets/MoneyWiseXAnalysisSecurityBucket.java

Rule Violation Line
UnusedPrivateMethod Avoid unused private methods such as 'calculateDeltas()'. 685

io/github/tonywasher/joceanus/moneywise/atlas/reports/MoneyWiseXReportCapitalGains.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'myPrice'. 534
UnusedLocalVariable Avoid unused local variables such as 'myXchangeRate'. 535

io/github/tonywasher/joceanus/moneywise/atlas/reports/MoneyWiseXReportMarketGrowth.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'LOGGER'. 51
UnusedPrivateField Avoid unused private fields such as 'hasForeign'. 91

io/github/tonywasher/joceanus/moneywise/atlas/ui/dialog/MoneyWiseXTransactionDialog.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'theTransaction'. 133
UnusedLocalVariable Avoid unused local variables such as 'myYears'. 266
UnusedLocalVariable Avoid unused local variables such as 'myItem'. 334

io/github/tonywasher/joceanus/moneywise/data/validate/MoneyWiseValidateTransInfoSet.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'pCategory'. 394

io/github/tonywasher/joceanus/moneywise/data/validate/MoneyWiseValidateTransaction.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 649651
CollapsibleIfStatements This if statement could be combined with its parent 658660

Priority 4

io/github/tonywasher/joceanus/moneywise/data/statics/MoneyWiseCashCategoryClass.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseCashCategoryClass': 'PARENT' is already in scope because it is declared in an enclosing type 123

io/github/tonywasher/joceanus/moneywise/data/statics/MoneyWiseLoanCategoryClass.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseLoanCategoryClass': 'CREDITCARD' is already in scope because it is declared in an enclosing type 145

io/github/tonywasher/joceanus/moneywise/quicken/file/MoneyWiseQIFEvent.java

Rule Violation Line
UselessParentheses Useless parentheses around `myLine.startsWith(MoneyWiseQIFConstants.QIF_XFE...`. 346
UselessParentheses Useless parentheses around `myLine.endsWith(MoneyWiseQIFConstants.QIF_XFEREND)`. 347

io/github/tonywasher/joceanus/moneywise/quicken/file/MoneyWiseQIFParser.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFSection': 'values' is already in scope 347

Files

io/github/tonywasher/joceanus/moneywise/atlas/data/analysis/buckets/MoneyWiseXAnalysisSecurityBucket.java

Rule Violation Priority Line
UnusedPrivateMethod Avoid unused private methods such as 'calculateDeltas()'. 3 685

io/github/tonywasher/joceanus/moneywise/atlas/reports/MoneyWiseXReportCapitalGains.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'myPrice'. 3 534
UnusedLocalVariable Avoid unused local variables such as 'myXchangeRate'. 3 535

io/github/tonywasher/joceanus/moneywise/atlas/reports/MoneyWiseXReportMarketGrowth.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'LOGGER'. 3 51
UnusedPrivateField Avoid unused private fields such as 'hasForeign'. 3 91

io/github/tonywasher/joceanus/moneywise/atlas/ui/dialog/MoneyWiseXTransactionDialog.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'theTransaction'. 3 133
UnusedLocalVariable Avoid unused local variables such as 'myYears'. 3 266
UnusedLocalVariable Avoid unused local variables such as 'myItem'. 3 334

io/github/tonywasher/joceanus/moneywise/data/statics/MoneyWiseCashCategoryClass.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseCashCategoryClass': 'PARENT' is already in scope because it is declared in an enclosing type 4 123

io/github/tonywasher/joceanus/moneywise/data/statics/MoneyWiseLoanCategoryClass.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseLoanCategoryClass': 'CREDITCARD' is already in scope because it is declared in an enclosing type 4 145

io/github/tonywasher/joceanus/moneywise/data/validate/MoneyWiseValidateTransInfoSet.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'pCategory'. 3 394

io/github/tonywasher/joceanus/moneywise/data/validate/MoneyWiseValidateTransaction.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 649651
CollapsibleIfStatements This if statement could be combined with its parent 3 658660

io/github/tonywasher/joceanus/moneywise/quicken/file/MoneyWiseQIFEvent.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `myLine.startsWith(MoneyWiseQIFConstants.QIF_XFE...`. 4 346
UselessParentheses Useless parentheses around `myLine.endsWith(MoneyWiseQIFConstants.QIF_XFEREND)`. 4 347

io/github/tonywasher/joceanus/moneywise/quicken/file/MoneyWiseQIFParser.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFSection': 'values' is already in scope 4 347