PMD Results

The following document contains the results of PMD 7.20.0.

Violations By Priority

Priority 3

io/github/tonywasher/joceanus/moneywise/archive/MoneyWiseArchiveCache.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 687693

io/github/tonywasher/joceanus/moneywise/atlas/data/analysis/buckets/MoneyWiseXAnalysisSecurityBucket.java

Rule Violation Line
UnusedPrivateMethod Avoid unused private methods such as 'calculateDeltas()'. 684

io/github/tonywasher/joceanus/moneywise/atlas/reports/MoneyWiseXReportCapitalGains.java

Rule Violation Line
UnusedLocalVariable Avoid unused local variables such as 'myPrice'. 538
UnusedLocalVariable Avoid unused local variables such as 'myXchangeRate'. 539

io/github/tonywasher/joceanus/moneywise/atlas/reports/MoneyWiseXReportMarketGrowth.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'LOGGER'. 51
UnusedPrivateField Avoid unused private fields such as 'hasForeign'. 91

io/github/tonywasher/joceanus/moneywise/atlas/ui/dialog/MoneyWiseXTransactionDialog.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'theTransaction'. 133
UnusedLocalVariable Avoid unused local variables such as 'myYears'. 266
UnusedLocalVariable Avoid unused local variables such as 'myItem'. 334

io/github/tonywasher/joceanus/moneywise/data/basic/MoneyWiseAssetBase.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 694696

io/github/tonywasher/joceanus/moneywise/data/validate/MoneyWiseValidateTransInfoSet.java

Rule Violation Line
UnusedFormalParameter Avoid unused method parameters such as 'pCategory'. 453

io/github/tonywasher/joceanus/moneywise/data/validate/MoneyWiseValidateTransaction.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 764766
CollapsibleIfStatements This if statement could be combined with its parent 773775

Priority 4

io/github/tonywasher/joceanus/moneywise/quicken/file/MoneyWiseQIFFile.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFFile': 'HASH_BASE' is already in scope because it is declared in an enclosing type 799
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFFile': 'HASH_BASE' is already in scope because it is declared in an enclosing type 801
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFFile': 'HASH_BASE' is already in scope because it is declared in an enclosing type 803
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFFile': 'HASH_BASE' is already in scope because it is declared in an enclosing type 805
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFFile': 'HASH_BASE' is already in scope because it is declared in an enclosing type 807

io/github/tonywasher/joceanus/moneywise/quicken/file/MoneyWiseQIFLine.java

Rule Violation Line
UselessParentheses Useless parentheses around `myLine.startsWith(QIF_XFERSTART)`. 973
UselessParentheses Useless parentheses around `myLine.endsWith(QIF_XFEREND)`. 974
UselessParentheses Useless parentheses around `myLine.startsWith(QIF_XFERSTART)`. 1267
UselessParentheses Useless parentheses around `myLine.endsWith(QIF_XFEREND)`. 1268

io/github/tonywasher/joceanus/moneywise/quicken/file/MoneyWiseQIFParser.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFSection': 'values' is already in scope 347

Files

io/github/tonywasher/joceanus/moneywise/archive/MoneyWiseArchiveCache.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 687693

io/github/tonywasher/joceanus/moneywise/atlas/data/analysis/buckets/MoneyWiseXAnalysisSecurityBucket.java

Rule Violation Priority Line
UnusedPrivateMethod Avoid unused private methods such as 'calculateDeltas()'. 3 684

io/github/tonywasher/joceanus/moneywise/atlas/reports/MoneyWiseXReportCapitalGains.java

Rule Violation Priority Line
UnusedLocalVariable Avoid unused local variables such as 'myPrice'. 3 538
UnusedLocalVariable Avoid unused local variables such as 'myXchangeRate'. 3 539

io/github/tonywasher/joceanus/moneywise/atlas/reports/MoneyWiseXReportMarketGrowth.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'LOGGER'. 3 51
UnusedPrivateField Avoid unused private fields such as 'hasForeign'. 3 91

io/github/tonywasher/joceanus/moneywise/atlas/ui/dialog/MoneyWiseXTransactionDialog.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'theTransaction'. 3 133
UnusedLocalVariable Avoid unused local variables such as 'myYears'. 3 266
UnusedLocalVariable Avoid unused local variables such as 'myItem'. 3 334

io/github/tonywasher/joceanus/moneywise/data/basic/MoneyWiseAssetBase.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 694696

io/github/tonywasher/joceanus/moneywise/data/validate/MoneyWiseValidateTransInfoSet.java

Rule Violation Priority Line
UnusedFormalParameter Avoid unused method parameters such as 'pCategory'. 3 453

io/github/tonywasher/joceanus/moneywise/data/validate/MoneyWiseValidateTransaction.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 764766
CollapsibleIfStatements This if statement could be combined with its parent 3 773775

io/github/tonywasher/joceanus/moneywise/quicken/file/MoneyWiseQIFFile.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFFile': 'HASH_BASE' is already in scope because it is declared in an enclosing type 4 799
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFFile': 'HASH_BASE' is already in scope because it is declared in an enclosing type 4 801
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFFile': 'HASH_BASE' is already in scope because it is declared in an enclosing type 4 803
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFFile': 'HASH_BASE' is already in scope because it is declared in an enclosing type 4 805
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFFile': 'HASH_BASE' is already in scope because it is declared in an enclosing type 4 807

io/github/tonywasher/joceanus/moneywise/quicken/file/MoneyWiseQIFLine.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `myLine.startsWith(QIF_XFERSTART)`. 4 973
UselessParentheses Useless parentheses around `myLine.endsWith(QIF_XFEREND)`. 4 974
UselessParentheses Useless parentheses around `myLine.startsWith(QIF_XFERSTART)`. 4 1267
UselessParentheses Useless parentheses around `myLine.endsWith(QIF_XFEREND)`. 4 1268

io/github/tonywasher/joceanus/moneywise/quicken/file/MoneyWiseQIFParser.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'MoneyWiseQIFSection': 'values' is already in scope 4 347